RFR: 8361370: runtime/Thread/TestThreadDumpMonitorContention.java fails due to time out on Windows [v2]
Anton Artemov
duke at openjdk.org
Tue Aug 26 07:55:52 UTC 2025
On Tue, 26 Aug 2025 05:34:01 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8361370: Added explanatory comment.
>
> test/hotspot/jtreg/runtime/Thread/TestThreadDumpMonitorContention.java line 56:
>
>> 54: // the attach streaming output is enabled and the tool output is lengthy we can get both buffers (the attach
>> 55: // channel and the tool redirection buffer) full and the test hangs.
>> 56: // Instead the attach operation output is buffered and is sent after the operation is completed
>
> Suggestion:
>
> // jstack streaming output should be disabled because if the attach operation is executed at a safepoint,
> // the attach streaming output is enabled, and the tool output is lengthy, then we can get both buffers (the attach
> // channel and the tool redirection buffer) full and the test hangs.
> // Instead the attach operation output is buffered and is sent after the operation is completed.
Thanks for spotting, addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26895#discussion_r2300125616
More information about the hotspot-runtime-dev
mailing list