RFR: 8365975: Sort share/memory includes [v2]
Julian Waters
jwaters at openjdk.org
Tue Aug 26 12:34:39 UTC 2025
On Fri, 22 Aug 2025 10:01:30 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
>> This PR sorts the includes in `hotspot/share/memory` using `SortIncludes.java`. I'm also adding the directory to `TestIncludesAreSorted`, and removing a couple of unnecessary include statements.
>>
>> Passes `tier1`.
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>
> revert
I've never actually used the include sorting tool before. I see that it (SortIncludes.java) lives under jtreg, a strange place for a utility tool. Is it invoked automatically as part of the build process, or does one invoke it manually only when it's desired to sort includes of source files in a given directory? If it's the latter, it might be more suitable to be in src/utils instead. I digress, just thinking out loud here. The change itself is fine.
-------------
Marked as reviewed by jwaters (Committer).
PR Review: https://git.openjdk.org/jdk/pull/26897#pullrequestreview-3155421239
More information about the hotspot-runtime-dev
mailing list