RFR: 8364816: GetLastError() in os_windows.cpp should not store value to errno [v2]
Anton Artemov
duke at openjdk.org
Wed Aug 27 07:37:28 UTC 2025
> Hi, please consider the following changes:
>
> In `os_windows.cpp` in a few places results returned by `GetLastError()` are stored to `errno`. However, `errno` has no relation to `GetLastError()`, and their ranges are not the same.
>
> Results of `GetLastError()` should be stored into variables of type `DWORD`.
>
> The removed section in `src/hotspot/share/cds/aotClassLocation.cpp` was relying on values returned by `GetLastError()` and stored to `errno` in `os::stat()`. Though the logic was correct, these values should not be stored to `errno`. The functionality is preserved by storing a **valid** value `ENOENT` to `errno` in `os::stat()`.
>
> Tested in tiers 1 - 3.
Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
8364816: Fixed misleading comments.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26901/files
- new: https://git.openjdk.org/jdk/pull/26901/files/a2c42247..45f85e10
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26901&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26901&range=00-01
Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/26901.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26901/head:pull/26901
PR: https://git.openjdk.org/jdk/pull/26901
More information about the hotspot-runtime-dev
mailing list