RFR: 8364816: GetLastError() in os_windows.cpp should not store value to errno [v5]

Anton Artemov duke at openjdk.org
Fri Aug 29 08:50:06 UTC 2025


On Fri, 29 Aug 2025 05:54:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8364816: Fixed _wopen case.
>
> src/hotspot/os/windows/os_windows.cpp line 5034:
> 
>> 5032:   // if opening files failed, errno has been set to indicate the problem
>> 5033:   if (fd == -1) {
>> 5034:     log_debug(os)("os::open() failed to _wopen: errno->%ld.", errno);
> 
> Suggestion:
> 
>     log_debug(os)("os::open() failed to _wopen: errno->%s.", strerror(errno));

Changed as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26901#discussion_r2309572930


More information about the hotspot-runtime-dev mailing list