RFR: 8372802: PrintFlagsFinal should also print locked flags [v2]
Thomas Stuefe
stuefe at openjdk.org
Wed Dec 3 13:11:08 UTC 2025
On Mon, 1 Dec 2025 20:24:06 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:
>> This change aims to provide a way to print all flags including "locked" ones (e.g. Diagnostic and Experimental) without having to explicitly set `+UnlockExperimentalVMOptions` or `+UnlockDiagnosticVMOptions`
>>
>> This applies to the following VM options: `PrintFlagsFinal` , `PrintFlagsRanges`, `PrintFlagsInitial`, `PrintFlagsWithComments`, `-XprintFlags`, as well as the `PrintVMFlagsDCmd` diagnostic command (when set to show all flags).
>>
>> Places that print out only flags that have been changed (i.e. that skip flags with default values), like when during the generation of hs_err reports, are not affected by this.
>
> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed unnecessary jdk.internal.misc module declaration
test/hotspot/jtreg/runtime/CommandLine/PrintAllFlags.java line 71:
> 69: }
> 70: }
> 71: }
Possibly shorter code: could you not just collect the Set twice, once for + and once for - UnlockXXX, and then use something Set.equals to assert equality?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28579#discussion_r2585047002
More information about the hotspot-runtime-dev
mailing list