RFR: 8373293: Change the exception handling in TestNestHostErrorWithMultiThread.java [v2]
David Holmes
dholmes at openjdk.org
Tue Dec 9 04:10:30 UTC 2025
On Tue, 9 Dec 2025 02:03:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reviewer suggestion
>
> I don't have prior knowledge of this test, but this refactoring/cleanup in context of this test failure looks good to me.
Thanks for the review @jaikiran !
> test/hotspot/jtreg/runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java line 68:
>
>> 66: }
>> 67: } catch (InterruptedException e) {
>> 68: throw new Error("Unexpected interrupt");
>
> Hello David, while at it, it might be good to even include the `e` as the `cause` of this `Error`. That way we get to see which `join()` line in that try block resulted in the `InterruptedException`.
Done
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28713#issuecomment-3630166865
PR Review Comment: https://git.openjdk.org/jdk/pull/28713#discussion_r2601009479
More information about the hotspot-runtime-dev
mailing list