RFR: 8373295: Wrong log tag for UseCompressedOops ergo setting [v2]

David Holmes dholmes at openjdk.org
Tue Dec 9 07:35:54 UTC 2025


On Tue, 9 Dec 2025 07:22:32 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this trivial change: Ergonomic settings of `UseCompressedOops` should be logged with `log_debug(gc, heap, coops)`
>> 
>> 
>> Note: this is the same log channel used just a few lines above.
>> 
>> https://github.com/openjdk/jdk/blob/c9ab330b7bdd3cc2410ffdb336a63aa0ac7256a3/src/hotspot/share/runtime/arguments.cpp#L1579-L1586
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed test case that checks the old log but is no longer relevant

If test is no longer relevant then change seems fine.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28716#pullrequestreview-3555901105


More information about the hotspot-runtime-dev mailing list