RFR: 8371651: [AArch64] Populate CPU _features flag on Windows

Brian Stafford bstafford at openjdk.org
Wed Dec 10 00:04:36 UTC 2025


On Fri, 21 Nov 2025 21:25:05 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> Populate CPU feature flags on Windows/AArch64 to enable CPU features CRC32, AES, SHA1, SHA2, SHA3, SHA512, PMULL, ASIMD, LSE, SVE, SVE2 and SVEBITPERM.
> 
> Tests performed:  jtreg tier1 & tier2

LGTM

src/hotspot/os_cpu/windows_aarch64/vm_version_windows_aarch64.cpp line 31:

> 29: int VM_Version::get_current_sve_vector_length() {
> 30:   assert(VM_Version::supports_sve(), "should not call this");
> 31:   // TODO: This is not available in the Windows SDK yet , so conservatively go with the lowest value (128 bits)

nit: no space before comma

src/hotspot/os_cpu/windows_aarch64/vm_version_windows_aarch64.cpp line 38:

> 36: int VM_Version::set_and_get_current_sve_vector_length(int length) {
> 37:   assert(VM_Version::supports_sve(), "should not call this");
> 38:   // TODO: This is not available in the Windows SDK yet , so conservatively go with the lowest value (128 bits)

nit: no space before comma

-------------

Marked as reviewed by bstafford (Author).

PR Review: https://git.openjdk.org/jdk/pull/28461#pullrequestreview-3560178222
PR Review Comment: https://git.openjdk.org/jdk/pull/28461#discussion_r2604698050
PR Review Comment: https://git.openjdk.org/jdk/pull/28461#discussion_r2604698430


More information about the hotspot-runtime-dev mailing list