RFR: 8373411: Crash when PrintSharedArchiveAndExit is enabled but shared heap is disabled

[Stefan Karlsson]

On Wed, 10 Dec 2025 17:28:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Found this while poking around at Valhalla that turned off heap sharing. The fix is simple, there's a missing HeapShared::is_loading() check that we missed when refactoring the object streaming code.
>
> test/hotspot/jtreg/runtime/cds/PrintSharedArchiveAndExitNoHeap.java line 26:
> 
>> 24: /**
>> 25:  * @test
>> 26:  * @summary Testing -XX:+PrintSharedArchiveAndExit option with no shared heap
> 
> Please add bug ID.

Just curious: why is that important? I would have guessed that the git history would be sufficient to figure this out.

> test/hotspot/jtreg/runtime/cds/PrintSharedArchiveAndExitNoHeap.java line 30:
> 
>> 28:  * @library /test/lib
>> 29:  * @modules java.base/jdk.internal.misc
>> 30:  *          java.management
> 
> Is this required?

I don't know. I copy-n-pasted the code from `PrintSharedArchiveAndExit.java` and didn't think about it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28741#discussion_r2609699814
PR Review Comment: https://git.openjdk.org/jdk/pull/28741#discussion_r2609726050