RFR: 8373411: Crash when PrintSharedArchiveAndExit is enabled but shared heap is disabled
Aleksey Shipilev
shade at openjdk.org
Thu Dec 11 09:32:56 UTC 2025
On Thu, 11 Dec 2025 08:56:54 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> Personally, I think it is redundant, because the second assert would catch a failure of the first. But if you all think this is better, then I'll add it.
Meh, can go either way. Honestly, I find it confusing that `HeapShared::is_loading_mapping_mode()` is not a subset of `HeapShared::is_loading()`. The name suggests it is. In other words, I would have expected `is_loading_mapping_mode() == true` implies `is_loading() == true`. But I won't quibble for this patch.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28741#issuecomment-3641040274
More information about the hotspot-runtime-dev
mailing list