RFR: 8373557: Remove stale comments after JDK-8372584
Johan Sjölen
jsjolen at openjdk.org
Fri Dec 12 10:33:07 UTC 2025
On Thu, 11 Dec 2025 22:03:54 GMT, Jonas Norlinder <jnorlinder at openjdk.org> wrote:
> Hi all,
>
> This is a small patch to fix stale comments after removing reading /proc to get user CPU time.
>
> A note on the proposed removal of:
>
> // This is the fastest way to get thread cpu time on Linux.
> // Returns cpu time (user+sys) for any thread, not only for current.
> // POSIX compliant clocks are implemented in the kernels 2.6.16+.
> // It might work on 2.6.10+ with a special kernel/glibc patch.
> // For reference, please, see IEEE Std 1003.1-2004:
> // http://www.unix.org/single_unix_specification
>
> jlong os::Linux::thread_cpu_time(clockid_t clockid) {
>
>
> Since we may call this method with a clockid_t that will only resolve user time this comment may be confusing. Moreover, I don't think we need to keep the comment here when POSIX compliant clock are implemented.
Marked as reviewed by jsjolen (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28777#pullrequestreview-3571264751
More information about the hotspot-runtime-dev
mailing list