RFR: 8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt [v2]

David Holmes dholmes at openjdk.org
Mon Dec 15 20:41:01 UTC 2025


> In the fix for JDK-8365526 we changed the `set_nest_host_error` code so that we would overwrite the message in the resolution error table, and free the previous copy of the message (the messages will always be the same). This was the wrong thing to do as the message could be in-use at the time it was freed, leading to either a missing message, or an assertion failure when we checked the messages for UTF8 validity.
> 
> The fix is to simply only ever set the message once (freeing it only when the entry is removed from the table).
> 
> Testing:
>  - TestNestHostErrorWithMultiThread.java with an augmented VM that inserts a delay that helped trigger the bug
>  - tiers 1-3 sanity
> 
> Thanks

David Holmes has updated the pull request incrementally with one additional commit since the last revision:

  Avoid memory leaks by passing stringStream

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28817/files
  - new: https://git.openjdk.org/jdk/pull/28817/files/e886320d..9332638b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28817&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28817&range=00-01

  Stats: 12 lines in 3 files changed: 1 ins; 2 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/28817.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28817/head:pull/28817

PR: https://git.openjdk.org/jdk/pull/28817


More information about the hotspot-runtime-dev mailing list