RFR: 8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt [v2]

[David Holmes]

On Mon, 15 Dec 2025 20:50:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Avoid memory leaks by passing stringStream
>
> Looks good. Two minor nits.

Thanks for the reviews @iklam and @jdksjolen !

> src/hotspot/share/classfile/resolutionErrors.cpp line 130:
> 
>> 128: 
>> 129: void ResolutionErrorEntry::set_nest_host_error(const char* message) {
>> 130:   assert(_nest_host_error == nullptr, "caller should have checked");
> 
> May also check that you're holding `SystemDictionary_lock`? That way you're more certain that the field has not been changed since the caller checked it.

Done

> src/hotspot/share/classfile/systemDictionary.cpp line 1881:
> 
>> 1879:         entry->set_nest_host_error(message.as_string(true /* on C-heap */));
>> 1880:       }
>> 1881:       else {
> 
> `} else {` should be in one line.

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28817#issuecomment-3657618865
PR Review Comment: https://git.openjdk.org/jdk/pull/28817#discussion_r2620858663
PR Review Comment: https://git.openjdk.org/jdk/pull/28817#discussion_r2620859053