RFR: 8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt [v3]

[Ioi Lam]

On Mon, 15 Dec 2025 21:13:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> In the fix for JDK-8365526 we changed the `set_nest_host_error` code so that we would overwrite the message in the resolution error table, and free the previous copy of the message (the messages will always be the same). This was the wrong thing to do as the message could be in-use at the time it was freed, leading to either a missing message, or an assertion failure when we checked the messages for UTF8 validity.
>> 
>> The fix is to simply only ever set the message once (freeing it only when the entry is removed from the table).
>> 
>> Testing:
>>  - TestNestHostErrorWithMultiThread.java with an augmented VM that inserts a delay that helped trigger the bug
>>  - tiers 1-3 sanity
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reviewer feedback

Marked as reviewed by iklam (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28817#pullrequestreview-3580481190