Integrated: 8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt
David Holmes
dholmes at openjdk.org
Tue Dec 16 00:23:04 UTC 2025
On Mon, 15 Dec 2025 04:15:09 GMT, David Holmes <dholmes at openjdk.org> wrote:
> In the fix for JDK-8365526 we changed the `set_nest_host_error` code so that we would overwrite the message in the resolution error table, and free the previous copy of the message (the messages will always be the same). This was the wrong thing to do as the message could be in-use at the time it was freed, leading to either a missing message, or an assertion failure when we checked the messages for UTF8 validity.
>
> The fix is to simply only ever set the message once (freeing it only when the entry is removed from the table).
>
> Testing:
> - TestNestHostErrorWithMultiThread.java with an augmented VM that inserts a delay that helped trigger the bug
> - tiers 1-3 sanity
>
> Thanks
This pull request has now been integrated.
Changeset: 1748737b
Author: David Holmes <dholmes at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1748737b99f283f69b4be0910b6623a27d804e68
Stats: 21 lines in 4 files changed: 5 ins; 4 del; 12 mod
8372988: Test runtime/Nestmates/membership/TestNestHostErrorWithMultiThread.java failed: Unexpected interrupt
Reviewed-by: coleenp, iklam, jsjolen
-------------
PR: https://git.openjdk.org/jdk/pull/28817
More information about the hotspot-runtime-dev
mailing list