RFR: 8373615: Improve HotSpot debug functions findclass() and findmethod [v4]
Ioi Lam
iklam at openjdk.org
Tue Dec 16 04:19:35 UTC 2025
On Mon, 15 Dec 2025 21:28:21 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into 8373615-improve-findclass-and-findmethod
>> - Fixed regex test problems on Windows
>> - Fixed test and added more test cases
>> - sort includes
>> - @ashu-mehra and @matias9927 review comments
>> - 8373615: Improve HotSpot debug functions findclass() and findmethod
>
> test/hotspot/gtest/runtime/test_classPrinter.cpp line 88:
>
>> 86:
>> 87: #ifndef PRODUCT
>> 88: // These are available only in debug builds
>
> Sorry for nitpicking but I see `PRINT_BYTECODE` and `PRINT_BYTECODE_ADDRESS` are available in product builds, only `PRINT_METHOD_DETAILS` relies on method present in debug build. Or did I miss something?
Thanks for noticing it. I've moved the `#if` around so that `PRINT_BYTECODE` and `PRINT_BYTECODE_ADDRESS` are tested in product builds.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28796#discussion_r2621700468
More information about the hotspot-runtime-dev
mailing list