RFR: 8372246: LogOutputList gtests should not use LogConfiguration LogOutputs [v2]
Johan Sjölen
jsjolen at openjdk.org
Tue Dec 16 15:00:58 UTC 2025
On Thu, 20 Nov 2025 13:16:28 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> A handful of `LogOutputList` tests uses `LogConfiguration::Std[out|err]Log` LogOutputs in its tests.
>> However these are not setup unless we run the tests in VM mode.
>>
>> I suggest we add some dummy `LogOutputs` for `StdoutLog` and `StderrLog` which these tests can use, so they are not depending being a VM test.
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'JDK-8372241' into JDK-8372246
> - LogOutputList gtests should not use LogConfiguration LogOutputs
Seems good to me!
-------------
Marked as reviewed by jsjolen (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28416#pullrequestreview-3583537463
More information about the hotspot-runtime-dev
mailing list