Integrated: 8373837: "assert(thread->is_VM_thread() || thread->is_Java_thread()) failed: Must be VMThread or JavaThread" on macosx-aarch64-26

[David Holmes]

On Thu, 18 Dec 2025 01:09:24 GMT, David Holmes <dholmes at openjdk.org> wrote:

> If the SR signal is delivered late, there is a small window where the JavaThread destructor has run (and so the referenced assert will fail), but the Thread destructor has not yet reached the point where `is_terminated` returns true, and so we proceed to the assertion, that then fails. The simple fix is to move the assertion into the branch for an active suspension request, which guarantees we **can't** be executing destructors yet. See JBS for gory details.
> 
> EDIT: s/can/can't/
> 
> Testing: tiers 1-3 (sanity)
> 
> Thanks

This pull request has now been integrated.

Changeset: f0add885
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f0add8854501f13b611220804dcb54d118c43717
Stats:     11 lines in 1 file changed: 5 ins; 5 del; 1 mod

8373837: "assert(thread->is_VM_thread() || thread->is_Java_thread()) failed: Must be VMThread or JavaThread" on macosx-aarch64-26

Reviewed-by: fbredberg, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/28883