RFR: 8373876: StackWalkNativeToJava print more output in case of failures [v2]

David Holmes dholmes at openjdk.org
Fri Dec 19 02:18:52 UTC 2025


On Thu, 18 Dec 2025 08:51:58 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> In case of failures the jtreg test StackWalkNativeToJava sometimes misses to print the 'bad' output we check. This makes analyzing errors hard, so better enhance the output .
>> The other checks ` output.shouldNotContain`   print already the diagnostic summary of output.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust check a little as suggested by David

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/ErrorHandling/StackWalkNativeToJava.java line 77:

> 75:         }
> 76: 
> 77:         assertTrue(res.length == 3, res.length - 1);

Suggestion:

        assertTrue(res.length == 3, res.length);

You need to adjust both parts

-------------

PR Review: https://git.openjdk.org/jdk/pull/28871#pullrequestreview-3596332734
PR Review Comment: https://git.openjdk.org/jdk/pull/28871#discussion_r2633325747


More information about the hotspot-runtime-dev mailing list