RFR: 8374178: Missing include in systemDictionary.cpp after JDK-8365526

Kim Barrett kbarrett at openjdk.org
Sun Dec 21 19:59:56 UTC 2025


On Sun, 21 Dec 2025 16:58:49 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this tiny fix of missing include in systemDictionary.cpp.
>> For how to reproduce the error, please see the JBS.
>> 
>> Thanks.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 92:
> 
>> 90: #ifdef ASSERT
>> 91: #include "oops/constantPool.inline.hpp"
>> 92: #endif
> 
> There's no need to put this in an `#if`, or else the includes will become cluttered over time. You can just put it in the regular include lines above.

+1 - we generally conditionalize includes based on optional features or (rarely (never?) in shared code)
platforms, not on build type.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28946#discussion_r2638067766


More information about the hotspot-runtime-dev mailing list