RFR: 8349580: Do not use address in MemTracker top level functions
    Gerard Ziemski 
    gziemski at openjdk.org
       
    Fri Feb  7 15:48:14 UTC 2025
    
    
  
On Fri, 7 Feb 2025 09:07:45 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> src/hotspot/share/nmt/memTracker.hpp line 142:
>> 
>>> 140:     if (!enabled()) return;
>>> 141:     if (addr != nullptr) {
>>> 142:       VirtualMemoryTracker::remove_released_region((address)addr, size);
>> 
>> What about here?
>
> Hi,
> 
> That's correct as VMT does take `address`, whilst the external API takes "regular" pointers.
Hmm, looks weird. Are we planning on cleaning this up further up the chain then?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23497#discussion_r1946738827
    
    
More information about the hotspot-runtime-dev
mailing list