RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v2]

David Holmes dholmes at openjdk.org
Mon Feb 10 10:31:15 UTC 2025


On Mon, 10 Feb 2025 08:48:59 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> To resolve runtime/os/windows/TestAvailableProcessors.java failure, I made "systeminfo.exe" executed with "chcp 437". This ensures that the English message "OS Version: " is output on localized windows platforms.
>> I added the path C:\Windows\System32 to make chcp command recognized on the GHA Windows test machine. Without this addition, GHA will fail.
>> After this fix, I verified that the test passed.
>> 
>> https://github.com/openjdk/jdk/pull/22142
>> I refer to this fix.
>> tools/jpackage/windows/Win8301247Test.java does not run in GHA, so the problems with recognition of chcp command did not occur before.
>> 
>> Thanks.
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform

@ktakakuri  I need to evaluate whether this is a general purpose fix that should work everywhere.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23536#pullrequestreview-2605330679


More information about the hotspot-runtime-dev mailing list