RFR: 8349771: Replace usages of -mx and -ms in some monitor tests [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Feb 11 10:07:11 UTC 2025
On Tue, 11 Feb 2025 09:33:26 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> This PR updates two runtime/Monitor tests to replace the usage of the outdated `-mx` and `-ms` java launcher options with `-Xmx` and `-Xms`.
>>
>> As noted in [JDK-8349771](https://bugs.openjdk.org/browse/JDK-8349771), these outdated options will soon be deprecated for removal from the java launcher code.
>>
>> Change has been verified locally, test-fix only, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> Add missing comma in file header
These changes look reasonable to me. I don't know why my `grep` missed these files in the JDK when I had proposed similar changes in different areas a few months back.
I'm guessing you have run these tests after this update and they continue to pass?
Please wait for reviews from others familiar with this area before integrating.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23553#pullrequestreview-2608234158
More information about the hotspot-runtime-dev
mailing list