RFR: 8349755: Fix corner case issues in async UL [v7]

[David Holmes]

On Wed, 12 Feb 2025 12:32:00 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Also does this mean we are going to crash on the very first log_debug? You have two logging statements that will trigger the crash but only one of them can be reached with the way the testing is structured.
>
> You're right, we do crash on the very first log_debug we reach (when in debug mode) as this hits the `ShouldNotReachHere()`. Both can be reached, but when one has been reached the other one won't be reached. I think it's fine, we're simply trying to see whether the recursive logging case is handled correctly.
> 
>> If we are going to crash we should add -XX:-CreateCoredumpOnCrash
> 
> What's your thinking here?

When a test knows it will crash we don't want to generate a coredump as we don't care about it. Dumping can take a significant time on some systems leading to timeouts.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23513#discussion_r1953572561