RFR: 8346661: Add a register print helper method and unify register printing
Matthias Baesken
mbaesken at openjdk.org
Thu Feb 13 08:34:14 UTC 2025
On Wed, 15 Jan 2025 16:47:24 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> > I think it is very difficult to handle the formatting alignment/indentation when using a per-register helper this way. But I also don't think it is worth the trouble of trying to write a print function that takes a set of registers and their descriptions and figures out maximum name lengths etc to get that layout correct.
> > To be honest the bang-for-buck here seems too low to be worthwhile IMO.
>
> I agree. The intention is good, but the savings are not that large IMHO.
Hi Thomas , I had planned to use this little refactoring to have a central method where it is easy to add coding at one central single place.
E.g. for highlighting special 'interesting' values like mem corruption patterns.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22894#issuecomment-2655866140
More information about the hotspot-runtime-dev
mailing list