RFR: 8349755: Fix corner case issues in async UL [v7]
Johan Sjölen
jsjolen at openjdk.org
Thu Feb 13 09:45:10 UTC 2025
On Thu, 13 Feb 2025 00:00:54 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> I meant to call it `NonProduct`, and the rest of your message is confusing to me so I've probably misunderstood what my test does and what `NOT_PRODUCT` means :-).
>>
>> I've got:
>>
>> ```c++
>> NOT_PRODUCT(log_debug(deathtest)("Induce a recursive log for testing");)
>>
>>
>> I thought `NON_PRODUCT` means that this is included regardless of `assert`s being enabled, but will not be shipped in a product build of the JDK. That's what I want to do, as that let's me test recursive logging without any asserts being triggered.
>>
>> I'll look into the test section suggestion.
>
> I've misunderstood your intention, but we only run tests on debug and product and your `@requires !vm.debug` means the test will run on product and it will do nothing because the log statements will not be there.
Aha, I see. Well, I think that I can re-work the code that let's us test it to accommodate for that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23513#discussion_r1954163312
More information about the hotspot-runtime-dev
mailing list