RFR: 8316397: StackTrace/Suspended/GetStackTraceSuspendedStressTest.java failed with: SingleStep event is NOT expected [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Feb 14 20:57:15 UTC 2025
On Fri, 14 Feb 2025 04:56:11 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Why would we suspend a platform thread in the middle of post_single_step? And what has this to do with the original proposal that only affected virtual threads???
We have not observed this issue for platform threads yet. It is why I did not want this fix to impact the platform threads behavior. Patricio shared his opinion (and I agree with that) that this issue is common for platform and virtual threads. It is possible to take one of two paths:
- make this fix for virtual threads only
- make this fix common for platform and virtual threads; I can try to update the failing test to prove we have the same issue for platform threads too; will correct the PR description then
> If we don't want a suspended thread to be able to post events we should have probably detected that at a higher-level where it makes sense for the thread to actually suspend.
Not sure what do you mean by "detected at a higher level". Do you mean: detect it in the `InterpreterRuntime::at_safepoint()` function? Otherwise, there are no other levels where it can be detected as it is triggered by execution of a Java bytecode in the interpreter.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23490#issuecomment-2660239780
More information about the hotspot-runtime-dev
mailing list