RFR: 8350214: Test gtest/AsyncLogGtest.java fails after JDK-8349755

[David Holmes]

On Tue, 18 Feb 2025 12:56:14 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> [8349755](https://bugs.openjdk.org/browse/JDK-8349755) introduced a bug in debug builds when running with `-Xlog:async -Xlog:all=debug`. Specifically, this will cause UL to select for `deathtest` and `deathtest2`, which should only be selected when explicitly asked for.
> 
> In order to fix this, I've added a small debug-only snippet which ensures that any wildcard selector does not select `deathtest` or `deathtest2`. I've also added a testcase in order to catch this regression.

I need to mull on this. It seems like an awful lot of extra code to support a testing scenario.

src/hotspot/share/logging/logConfiguration.cpp line 723:

> 721: 
> 722: 
> 723: #ifdef assert

That should be ASSERT

-------------

PR Review: https://git.openjdk.org/jdk/pull/23675#pullrequestreview-2625661434
PR Review Comment: https://git.openjdk.org/jdk/pull/23675#discussion_r1960972628