RFR: 8349923: Refactor StackMapTable constructor and StackMapReader [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Feb 19 17:15:03 UTC 2025


On Wed, 19 Feb 2025 14:54:31 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This patch refactors the `StackMapReader` to clean up the `StackMapTable` constructor. The `StackMapReader` class is extended to hold more fields used for verification purposes and allows for a simpler StackMapTable constructor. Additionally, in preparation for further changes to verification, the `_frame_count` may not be equal to the value reported by the classfile, so a new structure is used to generate the `_frame_array`. Verified with tier 1-5 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   David suggestions

This looks good.  David had good suggestions.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23645#pullrequestreview-2627476232


More information about the hotspot-runtime-dev mailing list