RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG=AOT_JDK=true" [v6]
Ioi Lam
iklam at openjdk.org
Wed Feb 19 19:20:13 UTC 2025
On Wed, 19 Feb 2025 14:21:40 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments from @erikj79
>
> make/test/BuildTestSetupAOT.gmk line 63:
>
>> 61: IMAGES_TARGETS += $(COPY_SETUP_AOT)
>> 62:
>> 63: build: $(TARGETS)
>
> The target `build` is no longer the default target in this makefile, so this line is dead code unless you change the call in Main.gmk by setting `TARGET := build`. You can also just remove this line as the default target `all` gets setup to depend on `$(TARGETS)` anyway in MakeFileEnd.gmk.
I removed this line and verified TestSetupAOT.class is still created inside the test image.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23620#discussion_r1962240880
More information about the hotspot-runtime-dev
mailing list