RFR: 8350214: Test gtest/AsyncLogGtest.java fails after JDK-8349755

[David Holmes]

On Wed, 19 Feb 2025 14:53:09 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 487:
>> 
>>> 485:           "Recursive logging death test")                                   \
>>> 486:   develop(bool, TestingAsyncLoggingDeathTestNoCrash, falseInDebug,          \
>>> 487:           "Recursive logging death test (no crash)")                        \
>> 
>> `falseInDebug` means `true` when `ASSERT` is not defined. Think these should just be `false`.
>
> Even if it does not matter because we guard the use of the flags by `ASSERT`, it looks strange that the values end up being `true`/

Agreed - these flags default to "false" always

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23695#discussion_r1962601439