RFR: 8350214: Test gtest/AsyncLogGtest.java fails after JDK-8349755 [v2]

[Johan Sjölen]

> Hi,
> 
> [8349755](https://bugs.openjdk.org/browse/JDK-8349755) introduced a bug in debug builds when running with -Xlog:async -Xlog:all=debug. Specifically, this will cause UL to select for deathtest and deathtest2, which should only be selected when explicitly asked for.
> 
> In order to fix this, I've added some develop-only globals. We now only log if either of the testing globals are set, and we only crash on recursive logging if `TestingAsyncLoggingDeathTestNoCrash` is set to `false`.
> 
> Let's go through the cases:
> 
> 
> -Xlog:all=debug => deathtest isn't logged because the globals aren't set => Only non-deathtest recursive logs crash (as it should be)
> -Xlog:all=debug + TestingAsyncLoggingDeathTestNoCrash => deathtest is logged, but TestingAsyncLoggingDeathTestNoCrash is true so the ShouldNotReachHere branch isn't taken
> -Xlog:all=debug + TestingAsyncLoggingDeathTest => deathtest is logged, and it crashes

Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:

  Fix bug

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23695/files
  - new: https://git.openjdk.org/jdk/pull/23695/files/1ac6540b..891d048a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23695&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23695&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/23695.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23695/head:pull/23695

PR: https://git.openjdk.org/jdk/pull/23695