RFR: 8350444: Check for verifer error in StackMapReader::check_offset() [v2]

David Holmes dholmes at openjdk.org
Fri Feb 21 03:33:52 UTC 2025


On Thu, 20 Feb 2025 23:02:09 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This small patch adds error propagation in the newly added `check_offset()` method. Verified with tier 1-5 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check for exception without TRAPS

BTW the fact this got through testing unnoticed indicates we have a gap in test coverage. We should see if we can fill that gap.

Though it may be that any verification error caused by check_offset would be quickly found by a following check and so we still fail as expected, just a little later in the verification process.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23717#issuecomment-2673299543


More information about the hotspot-runtime-dev mailing list