RFR: 8350444: Check for verifer error in StackMapReader::check_offset() [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Fri Feb 21 16:19:59 UTC 2025
On Fri, 21 Feb 2025 13:20:18 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Check for exception without TRAPS
>
> I assume that the callers to next() check that the frame has an error, the only effect of not having a CHECK_VERIFY(return) is that _prev_frame is set and frame is returned but the error is checked by the caller and not the return value. So I don't think there was an observable bug.
Thanks for the discussion and reviews @coleenp and @dholmes-ora!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23717#issuecomment-2674979773
More information about the hotspot-runtime-dev
mailing list