RFR: 8350499: Minimal build fails with slowdebug builds [v2]

Ao Qi aoqi at openjdk.org
Sat Feb 22 07:44:52 UTC 2025


On Sat, 22 Feb 2025 03:50:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Ao Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   include list order
>
> src/hotspot/share/classfile/verifier.cpp line 34:
> 
>> 32: #include "classfile/symbolTable.hpp"
>> 33: #include "classfile/systemDictionary.hpp"
>> 34: #if INCLUDE_CDS
> 
> Conditional includes go after the unconditional includes.  See HotSpot Style Guide.

Done. Thanks for the reminder.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23729#discussion_r1966465930


More information about the hotspot-runtime-dev mailing list