RFR: 8350499: Minimal build fails with slowdebug builds [v2]

[duke]

On Sat, 22 Feb 2025 07:42:37 GMT, Ao Qi <aoqi at openjdk.org> wrote:

>> minimal build fails with slowdebug builds after [8311208](https://github.com/openjdk/jdk/commit/498a58244d79) (permissions required):
>> 
>> 
>> Building target 'images' in configuration 'linux-x86_64-minimal-slowdebug'
>> /usr/bin/ld: /home/aoqi/work/theaoqi/jdk/build/linux-x86_64-minimal-slowdebug/hotspot/variant-minimal/libjvm/objs/verifier.o: in function `Verifier::verify(InstanceKlass*, bool, JavaThread*)':
>> /home/aoqi/work/theaoqi/jdk/src/hotspot/share/classfile/verifier.cpp:239: undefined reference to `SystemDictionaryShared::warn_excluded(InstanceKlass*, char const*)'
>> /usr/bin/ld: /home/aoqi/work/theaoqi/jdk/src/hotspot/share/classfile/verifier.cpp:240: undefined reference to `SystemDictionaryShared::set_excluded(InstanceKlass*)'
>> collect2: error: ld returned 1 exit status
>> gmake[3]: *** [lib/CompileJvm.gmk:174: /home/aoqi/work/theaoqi/jdk/build/linux-x86_64-minimal-slowdebug/support/modules_libs/java.base/minimal/libjvm.so] Error 1
>> gmake[2]: *** [make/Main.gmk:236: hotspot-minimal-libs] Error 2
>> 
>> ERROR: Build failed for target 'images' in configuration 'linux-x86_64-minimal-slowdebug' (exit code 2) 
>> 
>> 
>> It may be because the systemDictionaryShared.cpp file is [excluded](https://github.com/openjdk/jdk/blob/bd8ad309b59bceb3073a8d6411cca74e73508885/make/hotspot/lib/JvmFeatures.gmk#L130) when using slowdebug and minimal builds.
>
> Ao Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include list order

@theaoqi 
Your change (at version 56004f641a8435bb700dcf3137cc40c9612b45a6) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23729#issuecomment-2677248572