RFR: 8348536: Build fails with extra cflags -DLOG_PLEASE

David Holmes dholmes at openjdk.org
Mon Feb 24 03:25:52 UTC 2025


On Fri, 24 Jan 2025 06:36:34 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> This is complement implement PR of [JDK-8347990](https://bugs.openjdk.org/browse/JDK-8347990), which fix make fails with extra flags '-DLOG_PLEASE'. On the other hand, I think it's better check macro `LOG_PLEASE` has been defined or not before define it.
> Change has been verified locally, test-fix only, risk is low.

Okay. I am still seeing a number of other uses in the gtests so I guess @coleenp missed a few others.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23290#pullrequestreview-2635954986


More information about the hotspot-runtime-dev mailing list