RFR: 8348536: Remove remain SIZE_FORMAT usage after JDK-8347990 [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon Feb 24 15:52:03 UTC 2025
On Mon, 24 Feb 2025 15:32:16 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> This is complement implement PR of [JDK-8347990](https://bugs.openjdk.org/browse/JDK-8347990), which fix make fails with extra flags '-DLOG_PLEASE'.
>>
>> Change has been verified locally, test-fix only, risk is low.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove #ifndef LOG_PLEASE
I didn't see these with the final grep and now I see they're conditionally compiled out. There are a couple others here. Can you get these too?
gtest/nmt/test_nmt_totals.cpp: LOG("Deviation: n=" SSIZE_FORMAT ", s=" SSIZE_FORMAT ", ovrh=" SSIZE_FORMAT, \
gtest/runtime/test_virtualMemoryTracker.cpp: LOG("In reserved region " PTR_FORMAT ", size " SIZE_FORMAT_HEX ":", p2i(rmr->base()), rmr->size());
gtest/runtime/test_virtualMemoryTracker.cpp: LOG(" committed region: " PTR_FORMAT ", size " SIZE_FORMAT_HEX, p2i(region->base()), region->size());
test/hotspot/gtest/metaspace/test_blocktree.cpp line 146:
> 144: }
> 145:
> 146: LOG("%zu" ": %zu.", request_size, real_size);
This can be changed to:
"%zu: %zu.", removing the extra " ".
-------------
Changes requested by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23290#pullrequestreview-2637595410
PR Review Comment: https://git.openjdk.org/jdk/pull/23290#discussion_r1967917138
More information about the hotspot-runtime-dev
mailing list