RFR: 8348536: Remove remain SIZE_FORMAT usage after JDK-8347990 [v4]

David Holmes dholmes at openjdk.org
Tue Feb 25 04:34:55 UTC 2025


On Tue, 25 Feb 2025 00:05:07 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is complement implement PR of [JDK-8347990](https://bugs.openjdk.org/browse/JDK-8347990), which fix make fails with extra flags '-DLOG_PLEASE'.
>> 
>> Change has been verified locally, test-fix only, risk is low.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace SSIZE_FORMAT as %zd

Seems fine. Thanks

Okay so this is no longer about LOG_PLEASE but just the leftover SIZE_FORMAT.

> The way that macro is being used, I don't think it's intended to be globally enabled like that.

I don't see why not, but I will take that up in the other PR.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23290#pullrequestreview-2639220867
PR Comment: https://git.openjdk.org/jdk/pull/23290#issuecomment-2680449014


More information about the hotspot-runtime-dev mailing list