RFR: 8350584: Check the usage of LOG_PLEASE

[David Holmes]

On Tue, 25 Feb 2025 03:32:30 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> Seen discussion in https://github.com/openjdk/jdk/pull/23290#issuecomment-2678001782. The LOG_PLEASE macro seems currently being defined are debugging leftovers that shouldn't have been committed. It's definition is typically
> commented or uncommented to provide some additional logging for some tests of interest.
> 
> This PR comment out the `#define LOG_PLEASE` same to other gtests. Change has been verified locally, test-fix only, no risk.

Having debug logging enabled in some tests is not necessarily an issue that needs to be "fixed". You need to ask the person who enabled it why they did so.

If it is enabled in some tests then we do need to guard against redefinition incase it is globally enabled (and there is nothing wrong with that either).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23764#issuecomment-2680458000