RFR: 8348536: Remove remain SIZE_FORMAT usage after JDK-8347990

[SendaoYan]

On Mon, 24 Feb 2025 10:30:07 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Hi all,
>> This is complement implement PR of [JDK-8347990](https://bugs.openjdk.org/browse/JDK-8347990), which fix make fails with extra flags '-DLOG_PLEASE'.
>> 
>> Change has been verified locally, test-fix only, risk is low.
>
>> make fails with extra flags '-DLOG_PLEASE'
> 
> The way that macro is being used, I don't think it's intended to be globally enabled like that.  It's definition is typically
> commented or uncommented to provide some additional logging for some tests of interest.  I'm wondering if the places
> where it is currently being defined are debugging leftovers that shouldn't have been committed.
> 
> For example, I think the LOG_PLEASE and LOG_HERE in runtime/test_os_reserve_between.cpp should either comment
> out the LOG_PLEASE definition or just use ordinary logging.  Maybe @tstuefe has an opinion?
> 
> Maybe the changes related to LOG_PLEASE definitions ought to be removed and examined as a separate issue?
> It's still good that the lingering SIZE_FORMATs were uncovered and are being fixed.

Thanks @kimbarrett @coleenp @dholmes-ora for the suggestions and reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23290#issuecomment-2680728031