RFR: 8323807: Async UL: Add a stalling mode to async UL [v19]
Johan Sjölen
jsjolen at openjdk.org
Tue Feb 25 09:16:38 UTC 2025
On Tue, 25 Feb 2025 09:09:03 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Self-review
>
> src/hotspot/share/runtime/globals.hpp line 1874:
>
>> 1872: "Memory budget (in bytes) for the buffer of Asynchronous " \
>> 1873: "Logging (-Xlog:async).") \
>> 1874: range(DEBUG_ONLY(96) NOT_DEBUG(100*K), 50*M) \
>
> Why 96 when the test uses 192? I guess it could be anything.
Short answer: It should be 192, I was confused.
Long answer: I picked 96 because that's what I used when hard-coding the buffer size, but I forgot that we have 2 buffers who share `AsyncLogBufferSize` and 192/2 = 96.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22770#discussion_r1969328829
More information about the hotspot-runtime-dev
mailing list