RFR: 8323807: Async UL: Add a stalling mode to async UL [v19]
Johan Sjölen
jsjolen at openjdk.org
Tue Feb 25 09:53:58 UTC 2025
On Tue, 25 Feb 2025 08:32:40 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Self-review
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 40:
>
>> 38: Locker(Thread*& holder, PlatformMonitor& lock)
>> 39: : _holder(holder),
>> 40: _lock(lock) {
>
> The other constructor in this file indents the initializer list.
> Suggestion:
>
> : _holder(holder),
> _lock(lock) {
I did the opposite, and changed the style of the other constructor. AFAIK, the style that `Locker` has currently is the most common in Hotspot.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22770#discussion_r1969401037
More information about the hotspot-runtime-dev
mailing list