RFR: 8350584: Check the usage of LOG_PLEASE
SendaoYan
syan at openjdk.org
Tue Feb 25 10:43:52 UTC 2025
On Tue, 25 Feb 2025 04:34:12 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Having debug logging enabled in some tests is not necessarily an issue that needs to be "fixed". You need to ask the person who enabled it why they did so.
>
> If it is enabled in some tests then we do need to guard against redefinition incase it is globally enabled (and there is nothing wrong with that either).
@tstuefe @rkennke Hi, Does the `#define LOG_PLEASE` in gtests is necessary actually, should we comment out the `#define LOG_PLEASE`, because it will cause make report redefinition error when configure with arguments `--with-extra-cflags=-DLOG_PLEASE --with-extra-cxxflags=-DLOG_PLEASE`
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23764#issuecomment-2681530047
More information about the hotspot-runtime-dev
mailing list