RFR: 8348028: Unable to run gtests with CDS enabled

[David Holmes]

On Tue, 25 Feb 2025 00:51:55 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> A simple fix in `os::jvm_path()` so that gtest can be run with CDS (`-Xshare:on`). The fix is just to change the directory name from `hotspot` to `server`.
> Note that the bug doesn't exist on macOS and thus no change is required for `os_bsd.cpp`.
> 
> Testing:
> 
> - run gtest with -Xshare:on on linux-x64
> - tier1

We have never had a "hotspot" directory. I was under the impression this was a path used for jrt-fs not the actual on-disk filesystem, for which we should end up in the other part of the code.

I think this is a bug in the altjvm handling. Would be interesting to see what this code did pre-modules.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23758#issuecomment-2683341057