RFR: 8350616: Skip ValidateHazardPtrsClosure in non-debug builds [v2]

David Holmes dholmes at openjdk.org
Wed Feb 26 07:12:17 UTC 2025


On Wed, 26 Feb 2025 05:44:07 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change DEBUG to ASSERT
>
> src/hotspot/share/runtime/threadSMR.cpp line 369:
> 
>> 367: };
>> 368: 
>> 369: #ifdef DEBUG
> 
> Shouldn't that be s/DEBUG/ASSERT/ ?  And similarly for the use.

Ugghh! Thanks Kim. Yes a mental slip after initially using DEBUG_ONLY. I guess we will never fix that inconsistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23762#discussion_r1971047083


More information about the hotspot-runtime-dev mailing list