RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v2]
Kazuhisa Takakuri
ktakakuri at openjdk.org
Wed Feb 26 07:29:54 UTC 2025
On Wed, 12 Feb 2025 02:38:02 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>
> test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 68:
>
>> 66: //Execution command to prevent garbled characters
>> 67: command.addAll(List.of("cmd.exe", "/c", "set", "PATH=%PATH%;C:\\Windows\\System32;C:\\Windows\\System32\\wbem", "&&"));
>> 68: command.addAll(List.of("chcp", "437", ">nul", "2>&1", "&&"));
>
> I see the use of `chcp` in the test `./tools/jpackage/helpers/jdk/jpackage/test/Executor.java` so that is okay. However it doesn't set the path and it does not seem necessary to do so, and potentially assumes what the paths are anyway. So I think you can simplify this a little.
As well as tools/jpackage/windows/Win8301247Test.java, the tools tests is not included in jdk/tier1, so it will not run in GHA?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r1971069041
More information about the hotspot-runtime-dev
mailing list