RFR: 8348028: Unable to run gtests with CDS enabled [v3]

Ioi Lam iklam at openjdk.org
Thu Feb 27 03:29:59 UTC 2025


On Wed, 26 Feb 2025 19:50:43 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> A simple fix in `os::jvm_path()` so that gtest can be run with CDS (`-Xshare:on`). The fix is just to change the directory name from `hotspot` to `server`.
>> Note that the bug doesn't exist on macOS and thus no change is required for `os_bsd.cpp`.
>> 
>> Testing:
>> 
>> - run gtest with -Xshare:on on linux-x64
>> - tier1
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comments

LGTM

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23758#pullrequestreview-2646475181


More information about the hotspot-runtime-dev mailing list