RFR: 8348028: Unable to run gtests with CDS enabled [v3]

[Julian Waters]

On Wed, 26 Feb 2025 19:50:43 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> A simple fix in `os::jvm_path()` so that gtest can be run with CDS (`-Xshare:on`). The fix is just to change the directory name from `hotspot` to `server`.
>> Note that the bug doesn't exist on macOS and thus no change is required for `os_bsd.cpp`.
>> 
>> Testing:
>> 
>> - run gtest with -Xshare:on on linux-x64
>> - tier1
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comments

make/hotspot/lib/JvmFeatures.gmk line 36:

> 34: ################################################################################
> 35: 
> 36: JVM_CFLAGS_FEATURES += -DJVM_VARIANT=\"$(JVM_VARIANT)\"

Might it be a better idea to set -DJVM_VARIANT as the CXXFLAGS for cdsConfig.cpp directly instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23758#discussion_r1972905084