RFR: 8350824: New async logging gtest StallingModePreventsDroppedMessages fails

Johan Sjölen jsjolen at openjdk.org
Thu Feb 27 09:23:35 UTC 2025


Hi,

When I added async stalling mode I also added this gtest early in the process, and as tier1/GHA passed I did not look at the test again. However, the test does not run until much deeper in the CI/CD process for us, as that's when we turn on async logging explicitly for all gtests.

Looking at it now, it's clearly buggy. It doesn't check which async mode UL is in, and as `drop` is default, that makes it bound to fail. Besides, the goal of it is to check whether async stalling mode drops messages or not during stress. We already have an excellent test for that in JTReg, and this does run early as it spawns its own VM with the correct asynchronous mode specified. My suggested fix is to delete the gtest and add a dropped message check to the JTReg test instead.

-------------

Commit messages:
 - Fix async test in drop tests
 - Add check in JTReg
 - Delete poorly devised test

Changes: https://git.openjdk.org/jdk/pull/23819/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23819&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8350824
  Stats: 24 lines in 2 files changed: 5 ins; 12 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/23819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23819/head:pull/23819

PR: https://git.openjdk.org/jdk/pull/23819


More information about the hotspot-runtime-dev mailing list